Customizing the dialog box

sijiazhao · May 19, 2020, 7:30pm

See forum post and pull request to fix this bug:

github.com/psychopy/psychojs

BF: Multiple fixes, mostly re GUI dlg; fixes #52

psychopy:master ← sijiazhao:master

opened 06:38PM - 19 May 20 UTC

sijiazhao

+88 -102

- Fix Window._setupPixi: use `resolution: window.devicePixelRatio` to prevent bl…urriness on HiDPI displays - Multiple GUI.DlgFromDict fixes: - - use `$.escapeSelector()` to prevent special characters in questions causing problems in element IDs (Fixes psychopy/psychojs#52) - - label elements now properly select the corresponding input element (use `keyId`, not `key`) - - use `.oninput` to detect input change to remove need to unselect the input element before clicking OK button - GUI._onKeyChange now properly handles dropdown boxes (previously `_nbSetRequiredKeys++` increments continuously just by toggling dropdown options or focussing/unfocussing input elements): - - GUI._onKeyChange: use `gui._setRequiredKeys.set(event.target, true);` and `gui._setRequiredKeys.delete(event.target);` - - GUI.DlgFromDict: use `this._setRequiredKeys = new Map()` - - GUI._updateOkButtonStatus: use `this._setRequiredKeys.size` in conditional check - ServerManager.downloadResources, ._downloadRegisteredResources: only process and download new resources, ignore existing resources - Dialogs are now properly destroyed and removed from DOM when closed (previously destroyed but not removed causing duplicate element IDs, jQuery sometimes recreates old dialogs, so GUI._updateOkButtonStatus updates the wrong button): - - Remove unnecessary GUI.destroyDialog - - GUI.dialog: remove `this.destroyDialog();` and change `$(this).dialog("close");` to `$(this).dialog("destroy").remove();` - - GUI.DlgFromDict: add `$(this).dialog("destroy").remove()` to `close: ...` property of `$('#expDialog').dialog` - - PsychoJS.quit: remove unnecessary `self._gui.destroyDialog();`

Topic		Replies	Views
Customise the online dialog box to start the experiment Online experiments dialog , expinfo	8	1889	June 1, 2020
Customizing the dialog box (Removing input field but keeping text) Online experiments	1	746	April 21, 2020
Text responses in JavaScript: Dialogue boxes Online experiments	14	2129	June 16, 2021
How to require a participant ID? Online experiments	2	1642	January 15, 2020
Experiment quits after dialog box Builder	3	568	April 15, 2018

Customizing the dialog box

Related topics