Is countdowntimer() still using self.add() instead of self.addtime()?

Normega · July 27, 2023, 7:44pm

Hi, I’m really enjoying all the improvements to Psychopy, thanks!

I keep getting warnings thrown using core.Countdowntimer() Psychopy 2023.1.3 that:
“WARNING:root:DEPRECATED: Clock.add() is deprecated in favor of .addTime() due to the counterintuitive design (it added time to the baseline, which reduced the values returned from getTime()”

I know that this was apparently resolved, but the documentation for psychopy clock looks like the countdowntimer is still using self.add() instead of self. addtime() - it is on line 226 of

github.com

psychopy/versions/blob/master/psychopy/clock.py

#!/usr/bin/env python
# -*- coding: utf-8 -*-

"""
Created on Tue Apr 23 11:28:32 2013

Provides the high resolution timebase used by psychopy, and defines some time
related utility Classes.

Moved functionality from core.py so a common code
base could be used in core.py and logging.py; vs. duplicating the getTime and
Clock logic.

@author: Sol
@author: Jon
"""

# Part of the PsychoPy library
# Copyright (C) 2002-2018 Jonathan Peirce (C) 2019-2022 Open Science Tools Ltd.
# Distributed under the terms of the GNU General Public License (GPL).

This file has been truncated. show original

Is it possible to change this to self.addtime() in the next version? I’m not an expert on pushing things to git so maybe it can be added to the bugfix list so it stops throwing the warning?

replicate warning code:
from psychopy import visual, event, core
timer = core.CountdownTimer(5)
while timer.getTime() > 0:

Thanks!
Norm

jon · July 28, 2023, 1:31pm

Hi @Normega this one has actually been fixed by this commit in the repository:

Hopefully you’ll have no more issues in 2023.2.x onwards (but do check your timing works as expected)

Normega · July 28, 2023, 1:51pm

Oh perfect, thanks I’ll update now